Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confluence] New method 'scrap_regex_from_page' + docs + example #1327

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

gkowalc
Copy link
Contributor

@gkowalc gkowalc commented Feb 4, 2024

This method performs the same function as scrap_regex_from_issue for jira:

  • For given page_id and regex variable it returns a list of regex matches from a confluence page html storage format.

  • Docs + examples included.

  • Method tested on confluence cloud and latest server LTS version.

  • I also added one additional condition to the scrap_regex_from_issue (JIRA) method ( to prevent NoneType error)

@codecov-commenter
Copy link

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (7c3dcee) 34.35% compared to head (4db577a) 34.31%.

Files Patch % Lines
atlassian/confluence.py 14.28% 12 Missing ⚠️
atlassian/jira.py 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
- Coverage   34.35%   34.31%   -0.04%     
==========================================
  Files          45       45              
  Lines        8302     8317      +15     
  Branches     1158     1163       +5     
==========================================
+ Hits         2852     2854       +2     
- Misses       5336     5349      +13     
  Partials      114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik
Copy link
Member

gonchik commented Feb 4, 2024

@gkowalc could you a use cases please ?

@gkowalc
Copy link
Contributor Author

gkowalc commented Feb 5, 2024

@gonchik do you mean what are the use cases of this method?

  • Loop through the pages within a space to get hardcoded links/customer data etc. Also feature can be extended in a way to update those regex values with the new value
  • Security/compliance requirement: searching for credentials/passwords added to confluence pages by the users
  • Main Confluence search functionality with applied regex is not ideal and might not be able to retrieve all results.

@gonchik gonchik merged commit 416a2b0 into atlassian-api:master Feb 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants