Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new property of Crowd class #1402

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

ChowRex
Copy link
Contributor

@ChowRex ChowRex commented May 27, 2024

  • Fix lxml CVE, using bs4 to replace.
  • Add a property for Crowd class to retrieves full details of all group memberships.

- Fix `lxml` CVE, using `bs4` to replace.
- Add a property for Crowd class to retrieves full details of all group memberships.
@ChowRex
Copy link
Contributor Author

ChowRex commented May 27, 2024

Hi @gonchik !
As your said early (#1400 (comment)), I fixed this CVE by using bs4.

Using `double-quotes` to replace `single-quotes`.
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 34.37%. Comparing base (b81fff5) to head (65f655c).
Report is 14 commits behind head on master.

Files Patch % Lines
atlassian/crowd.py 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   34.39%   34.37%   -0.02%     
==========================================
  Files          46       46              
  Lines        8569     8582      +13     
  Branches     1598     1601       +3     
==========================================
+ Hits         2947     2950       +3     
- Misses       5499     5509      +10     
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik
Copy link
Member

gonchik commented May 27, 2024

@ChowRex Thank you!

@gonchik gonchik merged commit 1bb6107 into atlassian-api:master May 27, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants