Feature/saml loop fix #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user who has an account on the IdP system but doesn't have permission for the given app tried to log in, they would see an infinite loop of SAML requests insteaed of a nice error. AFAIK, this only occurred in ADFS/Azure AD. This fixes that by upgrading the Spring Boot SAML library to the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the build scripts for the Search UI application to use Yarn instead of NPM, similarly to the way the SUIT library was updated recently.
Note, this PR was originally intended to fix the SAML looping issue for PLAT-44732. That change was committed and merged separately leaving this PR solely responsible for dealing with the change to Yarn.