issue-113: Add share search #114
Conversation
klk1010
added
the
merge conflicts
nikhilj13
removed
the
merge conflicts
There was a problem hiding this comment.
I think it makes more sense to have this be a completely separate component from the SearchBar. On the search page (in Search UI), you can then include it right after the <SearchBar> component. but this way you don't have to complicate SearchBar and you don't have to pass all of the properties you want this component to have through the SearchBar's properties.
Does that make sense?
| @@ -283,6 +288,18 @@ class SearchBar extends React.Component<SearchBarDefaultProps, SearchBarProps, S | |||
| } | |||
| } | |||
|
|
|||
| //eslint-disable-next-line | |||
There was a problem hiding this comment.
Why is the eslint-disable-next-line here?
| shareSearch() { | ||
| const username = AuthUtils.getUserName(AuthUtils.getSavedUser()); | ||
| const yourMessage = | ||
| 'Hey,\n\nI think you would be interested in these search results that I found using the most cognitive and ' + |
There was a problem hiding this comment.
This message should be a property. In a PoV this makes sense, but if someone wants to use it in a production system, they'd probably want to have different text.
| `intuitive search platform called Attivio. Here is the link :)\n${window.location.href} | ||
| \nLet me know if you have any questions!\n\nBest,\n${username}`; | ||
| const subject = 'Search results I found using Attivio!'; | ||
| const emailLink = '[email protected]'; |
There was a problem hiding this comment.
The target email should be a property too, although it should default to being empty, I think... In general, it doesn't make sense to have the address come up pre-filled to something no one will use... (for a PoV, sure...)
| const shareSearch = this.props.shareSearch ? ( | ||
| <span | ||
| className="attivio-smalltoolbar-btn" | ||
| title="Share this search via Email" |
There was a problem hiding this comment.
"Email" shouldn't be capitalized.
Adds a share search icon next to the SearchBar. This icon is hidden by default but if you set the sharesearch prop for SearchBar to true, you'll be able to see it.
Here's an example:
