Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBalance is not a generic ERC20 metadata #49

Open
0x3bfc opened this issue Jun 29, 2021 · 0 comments
Open

getBalance is not a generic ERC20 metadata #49

0x3bfc opened this issue Jun 29, 2021 · 0 comments
Assignees
@0x3bfc
Labels
enhancement New feature or request

Comments

@0x3bfc
Copy link
Contributor

0x3bfc commented Jun 29, 2021 •
edited
Loading

The user's balance is user centric metadata. It should be used outside the getErc20Data.

rainbow-bridge-client/packages/nep141-erc20/src/natural-erc20/getMetadata.js

Line 72 in f1039b4

getBalance(address, user),

and getBalance should be exported here:

rainbow-bridge-client/packages/nep141-erc20/src/natural-erc20/getMetadata.js

Line 5 in f1039b4

async function getBalance (address, user) {

@0x3bfc 0x3bfc changed the title getUserBalance is not a generic ERC20 metadata getBalance is not a generic ERC20 metadata Jun 29, 2021
0x3bfc added a commit that referenced this issue Jun 29, 2021
@0x3bfc
fix (#49)
e887c85
@0x3bfc 0x3bfc mentioned this issue Jun 29, 2021
Closed
@0x3bfc 0x3bfc self-assigned this Jun 30, 2021
@0x3bfc 0x3bfc added the enhancement New feature or request label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x3bfc 0x3bfc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: user get balance aurora-is-near/rainbow-bridge-client
1 participant
@0x3bfc