New debug panel with XVIZ Parser and Log Viewer stats #306
Conversation
modules/core/src/index.js
Outdated
| @@ -61,3 +61,8 @@ export {default as _XVIZLoaderInterface} from './loaders/xviz-loader-interface'; | |||
| export {default as XVIZStreamLoader} from './loaders/xviz-stream-loader'; | |||
| export {default as XVIZLiveLoader} from './loaders/xviz-live-loader'; | |||
| export {default as XVIZFileLoader} from './loaders/xviz-file-loader'; | |||
|
|
|||
| // Debug | |||
| export {XvizWorkersStatus} from './debug/xviz-workers-status'; | |||
There was a problem hiding this comment.
well, at least for exports. We have a style guide for XVIZ to be either all upper or all lower, though I can't tell you where it's documented ;)
| @@ -102,7 +103,7 @@ export default class XVIZWebsocketLoader extends XVIZLoaderInterface { | |||
| message: message.data, | |||
| onResult: this.onXVIZMessage, | |||
| onError: this.onError, | |||
| debug: this._debug.bind('parse_message'), | |||
| debug: this.options.debug || this._debug.bind('parse_message'), | |||
There was a problem hiding this comment.
I think we still want to send the 'parse_message' on the _debug object regardless of options.debug
|
left a few inline comments. |
There was a problem hiding this comment.
Would it be possible in the test app to have a toggle to umount the component (the HUD too would be awesome) below the "show tooltip" one? I find when profiling it's very nice to be able to remove most of the react render calls so you more clearly see the deck.gl/streetscape issue after you have used the debug panel identify a slow down.
|
@jlisee Sure. Like this?
|
| debug: payload => { | ||
| this._debug.bind('parse_message'); | ||
| if (typeof this.options.debug === 'function') { | ||
| this.options.debug(payload); |
There was a problem hiding this comment.
this._debug is the same as this.options.debug with empty fallback.
| @@ -102,7 +103,12 @@ export default class XVIZWebsocketLoader extends XVIZLoaderInterface { | |||
| message: message.data, | |||
| onResult: this.onXVIZMessage, | |||
| onError: this.onError, | |||
| debug: this._debug.bind('parse_message'), | |||
| debug: payload => { | |||
| this._debug.bind('parse_message'); | |||
There was a problem hiding this comment.
It was a bug in the existing code. Should be debug: this._debug.bind(this, 'parse_message')
marionleborgne
force-pushed
the
debug-panel
branch
from
df66a50
to
071d9f0
Compare
Added a new debug panel with
@xviz/parserworker farm status +LogViewerstats chart:Note: an
XVIZWorkersMonitorinstance (calledmonitor) keeps track of the XVIZ worker farm status. Whenmonitor.update()is called, the workers status gets updated. This method is passed as a callback to@xviz/parser'sparseStreamMessagevia thedebugcallback argument. When the debug callback is called, the XVIZ workers status are updated in the monitor. This allows us to decorrelate the rate at which the monitor workers status gets updated (on each message byparseStreamMessage) from the rate at which a view component is updated (hereXvizWorkersStatusvia the monitor'sreportCallback). We don't want the view component to re-render on every incoming un-parsed XVIZ message, this would be too heavy.