Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to run website source docs from local repository #311

Merged
merged 1 commit into from
May 7, 2019
Merged

Add ability to run website source docs from local repository #311

merged 1 commit into from
May 7, 2019

Conversation

twojtasz
Copy link
Contributor

@twojtasz twojtasz commented May 3, 2019

No description provided.

Pessimistress
Pessimistress reviewed May 3, 2019
View reviewed changes
website/src/static/xviz-docs Outdated
@@ -0,0 +1 @@
../../../../xviz/docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These unfortunately will be copied when we build the website. Can you move them out of the static/ directory?

@twojtasz
Copy link
Contributor Author

twojtasz commented May 6, 2019

@Pessimistress Done, is src-local/static ok? Or basically any directory location that won't be part of the build. I tried building, but it failed with some issue (seems related to the ocular changes and the babel plugin settings again) I tried to fix it, but now it now longer works for me.

Can you work your magic. The build pipeline for JS/webpack is a bit too magical for me right now.

@twojtasz twojtasz mentioned this pull request May 6, 2019
Merged
@twojtasz twojtasz force-pushed the website-docs-local branch 2 times, most recently from f3a283f to c21f0f7 Compare May 7, 2019 18:34
@coveralls
Copy link

coveralls commented May 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 39.269% when pulling 755ea0c on website-docs-local into 651c485 on master.

@twojtasz
Add ability to run website source docs from local repository
755ea0c 
Put local symlinks in `src-local/static` so they are not included
in normal build.
@twojtasz twojtasz merged commit fdc3356 into master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twojtasz @coveralls @Pessimistress