-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debug callback of LogViewer #318
Conversation
@@ -155,13 +155,13 @@ export default class Core3DViewer extends PureComponent { | |||
_onMetrics = deckMetrics => { | |||
if (this.props.debug) { | |||
const metrics = { | |||
fps: deckMetrics.fps, | |||
redraw: deckMetrics.redraw || 0 | |||
fps: deckMetrics.frameRate.hz, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is fps
the same as hz
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, all stats have a field called hz
, and fps
refers to how many animation frame are requested per second.
This is experimental API and we will need to do a thorough audit in 7.1 time frame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @Pessimistress
@@ -155,13 +155,13 @@ export default class Core3DViewer extends PureComponent { | |||
_onMetrics = deckMetrics => { | |||
if (this.props.debug) { | |||
const metrics = { | |||
fps: deckMetrics.fps, | |||
redraw: deckMetrics.redraw || 0 | |||
fps: deckMetrics.frameRate.hz, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
For #315