Decouple XVIZWorkersMonitor instance from XVIZWorkersStatus component #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… + Rename "debug" to "perf"
marionleborgne
commented
May 10, 2019
| @@ -103,23 +117,45 @@ class Example extends PureComponent { | |||
| }) | |||
| .on('error', console.error) | |||
| .connect(); | |||
|
|
|||
| // Monitor the log | |||
There was a problem hiding this comment.
Updated the example app to reflect how the XVIZWorkersMonitor is now decoupled from the perf view components and its metrics passed as props to those view components.
twojtasz
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] Previously the XVIZWorkersMonitor was instantiated (and linked to the
log) on component mount. That was a mistake as the log can be destroyed and recreated independently from the component being mounted. This refactor extracts the log monitor from the component. We now only have view components to visualize the perf metrics that they receive as props. The log monitor creation & wiring can be handled outside of the view logic.