Changes to support the ALLCAPS spec change in XVIZ #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| treetable: XVIZTable, | ||
|
|
||
| // Normalize enums to uppercase | ||
| CONTAINER: XVIZContainer, |
There was a problem hiding this comment.
This is technically public API (users can override default components with their own). Can we cast component type to lowercase in _renderItem instead?
There was a problem hiding this comment.
I am doing this just for the default components then OK.
| streamMetadata[streamName] && streamMetadata[streamName].primitive_type === 'image' | ||
| streamMetadata[streamName] && | ||
| streamMetadata[streamName].primitive_type && | ||
| streamMetadata[streamName].primitive_type.toUpperCase() === 'IMAGE' |
There was a problem hiding this comment.
primitive_type === 'image' || primitive_type === 'IMAGE'
is more efficient.
jlisee
reviewed
Jun 7, 2019
| @@ -217,7 +217,7 @@ test('XVIZStreamLoader#connect, seek', t => { | |||
| loader.onXVIZMessage({type: LOG_STREAM_MESSAGE.METADATA, start_time: 1000, end_time: 1030}); | |||
| t.deepEquals( | |||
| socket.flush(), | |||
| [{type: 'xviz/transform_log', data: {start_timestamp: 1000, end_timestamp: 1010, id: '0'}}], | |||
| [{type: 'XVIZ/TRANSFORM_LOG', data: {start_timestamp: 1000, end_timestamp: 1010, id: '0'}}], | |||
There was a problem hiding this comment.
Just like aurora-opensource/xviz#477 I don't think we should change the type names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on aurora-opensource/xviz#477 and makes the expectation it will be published as beta.16. This cannot land until that is published.
This covers places in the code where any enumerated types where being referenced directly and will normalize them to UPPERCASE to support both existing data as well as new data. This should be backwards compatible with previously generated data but will have a hard dependency on the new xviz module version.
Testing was ran as follows:
yarn start-localusing local modules hitting AWS hosted datayarn start-streaming-localusing local modules hitting local XVIZ server with UPPERCASE datayarn start-localusing local modules hitting local XVIZ server with UPPERCASE datayarn start-localusing local modules and updated embedded test cases