-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing stream data component #361
Add missing stream data component #361
Conversation
…files to display missing data, instead of passing the missing information as a Prop to a component in Monochrome
…ner and the missing streams into the xviz layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! I think we want to move the missing data calculation to state so that we're not constantly redoing it and we want to make sure to extend the style prop so that you can pass in style.missingData and override the default styling. Also make sure to update xviz-metric.md
and xviz-plot.md
when you do that.
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
… data warning and move the identifying of missing stream data to componentWillReceiveProps func instead of in the render
…eflect the override
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nitpicky comment.
…ring, for plots modify the missingStreams to only update the state if the nextprops dependent variables have changed and are missing data
…o display the missingdata for metrics
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
…from theme, and update missing plot data to be more explicit
verticalGridLines={verticalGridLines} | ||
/> | ||
<MetricCard title={title} description={description} style={style} isLoading={false}> | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shorthand fragment - the "closing" fragment is on line 221.
This PR addresses issue 344.