Add missing stream data component #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files to display missing data, instead of passing the missing information as a Prop to a component in Monochrome
…ner and the missing streams into the xviz layer
rastalamm
requested review from
twojtasz,
Pessimistress,
marionleborgne and
jefftam23
shoshannamb
suggested changes
Jul 11, 2019
There was a problem hiding this comment.
Overall, looks good! I think we want to move the missing data calculation to state so that we're not constantly redoing it and we want to make sure to extend the style prop so that you can pass in style.missingData and override the default styling. Also make sure to update xviz-metric.md and xviz-plot.md when you do that.
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
… data warning and move the identifying of missing stream data to componentWillReceiveProps func instead of in the render
…eflect the override
…ring, for plots modify the missingStreams to only update the state if the nextprops dependent variables have changed and are missing data
…o display the missingdata for metrics
Pessimistress
approved these changes
Jul 16, 2019
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
modules/core/src/components/declarative-ui/missing-data-card.js
Outdated
Show resolved
Hide resolved
…from theme, and update missing plot data to be more explicit
| verticalGridLines={verticalGridLines} | ||
| /> | ||
| <MetricCard title={title} description={description} style={style} isLoading={false}> | ||
| <> |
There was a problem hiding this comment.
It's a shorthand fragment - the "closing" fragment is on line 221.
Pessimistress
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue 344.