backport yara patch for macOS #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is simple backports VirusTotal/yara#1540 to existed way apply patches to yara which is fixed avast#990
catap
force-pushed
the
yara-patch-backport
branch
from
cf69c3e
to
2539bf0
Compare
|
The patch seems good. Even though the code was merged to VirusTotal/yara I don't know when they will include it in a release. So I think merging this makes sense until then. |
|
Lets run TC tests. |
|
The tests have failed but they all pass when rebased onto the current master. The changes seem fine for now, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is simple backports VirusTotal/yara#1540 to existed way apply patches to yara which is fixed #990