Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if data is not empty in dotnet integer decoding functions #1030

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Check if data is not empty in dotnet integer decoding functions #1030

merged 3 commits into from
Oct 1, 2021

Conversation

HoundThe
Copy link
Member

Fix potential OOB read if passed data, to Signed/Unsigned dotnet decode function, is empty.

@ladislav-zezula
Copy link
Contributor

ladislav-zezula commented Sep 27, 2021 •
edited
Loading

All asserts are gone. Just a little question, why has the data type of result in decodeSigned() changed from std::int64_t to std::uint64_t?

@HoundThe
Copy link
Member Author

Oh thank you for that, that was a mistake.

@PeterMatula PeterMatula merged commit c6605e7 into avast:master Oct 1, 2021
PeterMatula added a commit that referenced this pull request Oct 1, 2021
@PeterMatula
CHANGELOF.md: add entry for #1030
9eeb7db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterMatula PeterMatula PeterMatula approved these changes

@ladislav-zezula ladislav-zezula Awaiting requested review from ladislav-zezula

Assignees

@PeterMatula PeterMatula

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HoundThe @ladislav-zezula @PeterMatula