Add detection support of Astrum InstallWizard. #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Astrum InstallWizard is an installation software from Thraex Software.
|
Let's run TeamCity tests. |
s3rvac
approved these changes
Apr 25, 2020
There was a problem hiding this comment.
The TC builds fail because the PR is not based on the current RetDec's master but the tests in avast/retdec-regression-tests#53 are based on the RetDec tests' master. Other than that, there is nothing wrong with the PR, so approving 👍
A tip for the future: Always base both PRs (RetDec and tests) on the current master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Astrum InstallWizard is an installation software from Thraex Software and this PR aims at providing Fileinfo an ability to detect installation files, created using that software, correctly.
The tests for this enhancment were added here.