Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed segfault on PE files whose IMAGE_FILE_HEADER is cut #839

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Fixed segfault on PE files whose IMAGE_FILE_HEADER is cut #839

merged 1 commit into from
Aug 14, 2020

Conversation

ladislav-zezula
Copy link
Contributor

@ladislav-zezula ladislav-zezula commented Aug 13, 2020 •
edited by s3rvac
Loading

Fixes #838.

@s3rvac s3rvac self-requested a review August 13, 2020 17:48
@s3rvac s3rvac self-assigned this Aug 13, 2020
@s3rvac
Copy link
Member

s3rvac commented Aug 13, 2020

Thank you for the fix. Could you please also add a regression test for it?

@ladislav-zezula
Copy link
Contributor Author

https://github.com/avast/retdec-regression-tests/tree/LZ_issue_838

@s3rvac s3rvac merged commit 4cf40b4 into master Aug 14, 2020
@s3rvac s3rvac deleted the LZ_issue_838 branch August 14, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac approved these changes

Assignees

@s3rvac s3rvac

Labels
bug C-fileinfo C-pelib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

retdec-fileinfo reads invalid memory when parsing a 138 B file
2 participants
@ladislav-zezula @s3rvac