Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lz issue 907 #908

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Lz issue 907 #908

merged 2 commits into from
Dec 18, 2020

Conversation

ladislav-zezula
Copy link
Contributor

@ladislav-zezula ladislav-zezula commented Dec 18, 2020 •
edited by s3rvac
Loading

Fixes #907.

s3rvac
s3rvac approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍 I have reviewed and tested the code, and both runtime and memory have dropped down (runtime to 3 seconds, memory to 300 MB).

The Linux build failure is unrelated to the present PR (a GitHub timeout). Other tests are passing, so I am going to merge the PR.

@s3rvac s3rvac merged commit ed02e64 into master Dec 18, 2020
@s3rvac s3rvac deleted the LZ_issue_907 branch December 18, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac approved these changes

Assignees

@s3rvac s3rvac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

retdec-fileinfo runs for a minute and uses 110 GB of RAM to analyze a 41 MB PE file
2 participants
@ladislav-zezula @s3rvac