Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look in node_modules #17

Closed
jackfranklin opened this issue Nov 17, 2016 · 3 comments
Closed

Don't look in node_modules #17

jackfranklin opened this issue Nov 17, 2016 · 3 comments

Comments

@jackfranklin
Copy link

gulp-elm for example has a Test.elm file that it tries to upgrade, which isn't needed. I'd suggest just avoiding that directory entirely.

@jackfranklin
Copy link
Author

I'm happy to make this PR too btw, just raising it now while I remember! If no one beats me to it I can do it tomorrow.

@avh4
Copy link
Owner

avh4 commented Nov 17, 2016

elm-upgrade only runs elm-format on folders that are listed as source-directories in the elm-package.json. However, if . is listed, then elm-format . will find files in node_modules. I think this issue should be moved to elm-format: https://github.com/avh4/elm-format/issues

@jackfranklin
Copy link
Author

Ah, I'll open an issue there. I think that my Haskell knowledge (or lack of) will prevent me doing the PR unfortunately. I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants