Take 2... Some minor refactors #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated_stats` to reduce repetitive code and enhance readability. 2. Consolidated error handling in `_pihole_api_get` to provide more consistent and clear error messages. 3. Encapsulated parsing of Pi-hole configuration into a separate method `_parse_piholes` within the `Config` class. 4. Improved logging throughout the script for better clarity and consistency. 5. Ensured consistent data types for fields in `_write_to_influxdb` to avoid type conflicts in InfluxDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_prepare_pointand_handle_authenticated_statsto reduce repetitive code and enhance readability._pihole_api_getto provide more consistent and clear error messages._parse_piholeswithin theConfigclass._write_to_influxdbto avoid type conflicts in InfluxDB.