-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies of PyTorch base image #375
base: main
Are you sure you want to change the base?
Conversation
9cef2a2
to
74cbfd7
Compare
export MAX_JOBS=32 && \ | ||
export NVCC_PREPEND_FLAGS="-t 32" && \ | ||
pip install -v -U git+https://github.com/facebookresearch/xformers.git@main#egg=xformers | ||
#RUN export TORCH_CUDA_ARCH_LIST="8.0;9.0+PTX" && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unless there's a reason to keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. Removed in 6fcba53. Thank you!
NVCC_GENCODE="-gencode=arch=compute_90,code=sm_90, -gencode=arch=compute_80,code=sm_80" \ | ||
&& rm -rf /tmp/nccl \ | ||
&& echo NCCL_SOCKET_IFNAME=^docker0,lo >> /etc/nccl.conf | ||
#RUN apt-get remove -y libnccl2 libnccl-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove if commented and no reason to keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep this as sometimes we want to install custom NCCL version.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.