Skip to content

Commit

Permalink
feat(codestarnotifications): add createdBy property for notificatio…
Browse files Browse the repository at this point in the history
…n rule (#30780)

### Issue # (if applicable)

### Reason for this change
The `createdBy` property existed in the L1 construct but was not present in the L2 construct

### Description of changes
- Add the `createdBy` property for `NotificationRule`, which was missing in the L2 construct.

### Description of how you validated changes
I Added a unit test for codestarnotifications and integration tests for pipeline and codestarnotifications

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
yuppe-kyupeen committed Jul 9, 2024
1 parent 9f4ec76 commit a68b418
Show file tree
Hide file tree
Showing 13 changed files with 2,386 additions and 0 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a68b418

Please sign in to comment.