-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(s3-notifications): unable to delete the existing S3 event notific…
…ations (under feature flag) (#30610) ### Issue # (if applicable) Closes #28915 ### Reason for this change Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications. ### Description of changes We fixed the hashing logic used to identify old vs external S3 event notifications ### Description of how you validated changes Manually tested, integration and unit tested the changes yes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
1 parent
1ad41e7
commit b880067
Showing
56 changed files
with
37,704 additions
and
2,461 deletions.
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
.../aws-lambda-event-sources/test/integ.s3.imported-bucket.js.snapshot/TestStack.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...lambda-event-sources/test/integ.s3.imported-bucket.js.snapshot/TestStacksetup.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...teg/test/aws-lambda-event-sources/test/integ.s3.imported-bucket.js.snapshot/manifest.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...k-integ/test/aws-lambda-event-sources/test/integ.s3.imported-bucket.js.snapshot/tree.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...est/aws-lambda-event-sources/test/integ.s3.js.snapshot/lambda-event-source-s3.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.