Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk init: Upgrade from netcoreapp3.1 to net6.0 #23921

Closed
2 tasks done
berviantoleo opened this issue Jan 31, 2023 · 3 comments · Fixed by #23926 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508
Closed
2 tasks done

cdk init: Upgrade from netcoreapp3.1 to net6.0 #23921

berviantoleo opened this issue Jan 31, 2023 · 3 comments · Fixed by #23926 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@berviantoleo
Copy link
Contributor

berviantoleo commented Jan 31, 2023 •
edited
Loading

Describe the feature

Any plan to upgrade the template from netcoreapp3.1 to net6.0? .NET Core 3.1 has reached the end of life for the support. Is it cdk support net6.0? If yes, I think it will be good to use net6.0.

Use Case

I want to reduce the warning.

warnings

Proposed Solution

Upgrade to net6.0 for the template

Other Information

I expect to update this line

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.62.2

Environment details (OS name and version, etc.)

Linux Manjaro 22.0.1 and .NET 6
@berviantoleo berviantoleo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jan 31, 2023
@berviantoleo berviantoleo mentioned this issue Jan 31, 2023
Merged
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 7, 2023
@peterwoodworth
Copy link
Contributor

Thanks for the PR - copying over from the PR for visibility here too, we will want to update jsii first

@berviantoleo
Copy link
Contributor Author

Thanks for the PR - copying over from the PR for visibility here too, we will want to update jsii first

Sure, I think we don't need to rush about it. I would like to help update too.

@berviantoleo berviantoleo mentioned this issue Feb 12, 2023
Merged
RomainMuller added a commit to aws/jsii that referenced this issue Feb 17, 2023
@berviantoleo @RomainMuller
feat(dotnet): update TargetFramework to net6.0 (#3957)
ae335ed 
BREAKING CHANGE: The runtime library for .NET & generated .NET bindings will no longer support netcoreapp3.1 after this release. Users are advised to upgrade their apps to use net6.0 or net7.0 instead.

Related: aws/aws-cdk#23926
Related: aws/aws-cdk#23921

Co-authored-by: 🧑🏻‍💻 Romain Marcadier <[email protected]>
@mergify mergify bot closed this as completed in #23926 Mar 1, 2023
mergify bot pushed a commit that referenced this issue Mar 1, 2023
@berviantoleo
feat(cli): update csharp & fsharp template to net6.0 (#23926)
3bd611d 
Update the csharp & fsharp templates to net6.0

NET Core 3.1 is EOL, see https://endoflife.date/dotnet

Closes #23921.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@cplee cplee mentioned this issue Mar 6, 2023
Merged
homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
@berviantoleo @homakk
feat(cli): update csharp & fsharp template to net6.0 (aws#23926)
c57f4c8 
Update the csharp & fsharp templates to net6.0

NET Core 3.1 is EOL, see https://endoflife.date/dotnet

Closes aws#23921.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@WontonSam WontonSam mentioned this issue Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
2 participants
@berviantoleo @peterwoodworth