Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ecs_patterns: add customname parameter to ScheduledFargateTaskImageOptions #27515

Closed
2 tasks
mrtngrbmn opened this issue Oct 12, 2023 · 2 comments · Fixed by #30357
Closed
2 tasks

aws_ecs_patterns: add customname parameter to ScheduledFargateTaskImageOptions #27515

mrtngrbmn opened this issue Oct 12, 2023 · 2 comments · Fixed by #30357
Assignees
@moelasmar
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mrtngrbmn
Copy link

Describe the feature

At the moment for a ScheduledFargateTaskImageOptions a new task definition is created with an automatically generated name.
This names are quite difficult to read in the AWS web console.

Please add a parameter to assign a custom name to the newly created task definition.

Same thing is possible in aws_ecs.FargateTaskDefinition with parameter family.

Use Case

I have to create a long list of tasks with similar task definitions. The name created by ScheduledFargateTaskImageOptions are not readable and makes it difficult to distinguish them from each other

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.84.0

Environment details (OS name and version, etc.)

Amazon Linux 2
@mrtngrbmn mrtngrbmn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Oct 12, 2023
@peterwoodworth
Copy link
Contributor

Hey, there are a number of similar reported FRs for our patterns constructs. Our patterns are opinionated, if you need fine control over the resources we suggest dropping down to the L2 constructs.

That said, we can still accept this as a feature request, thanks for the ask

@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@moelasmar moelasmar mentioned this issue May 28, 2024
Merged
1 task
@moelasmar moelasmar self-assigned this May 28, 2024
@mergify mergify bot closed this as completed in #30357 May 28, 2024
mergify bot pushed a commit that referenced this issue May 28, 2024
@moelasmar
feat(ecs-patterns): allow custom container name for Scheduled ecs and…
f54a945 
… fargate tasks (#30357)

### Issue # (if applicable)

Closes #30281
Closes #27515

### Reason for this change

The customers have difficulties to find the correct logs for some scheduled task if they have multiple tasks defined in the stack, as all tasks will use the same container name.

### Description of changes

Add the new optional property `ContainerName` in the `ScheduledTaskImageProps`, so customer can use it to customize the containers names. If this property is undefined, so we will use `ScheduledContainer` as default value.

### Description of how you validated changes

added unit and integration test cases, and verified them.

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

atanaspam pushed a commit to atanaspam/aws-cdk that referenced this issue Jun 3, 2024
@moelasmar @atanaspam
feat(ecs-patterns): allow custom container name for Scheduled ecs and…
46171b8 
… fargate tasks (aws#30357)

### Issue # (if applicable)

Closes aws#30281
Closes aws#27515

### Reason for this change

The customers have difficulties to find the correct logs for some scheduled task if they have multiple tasks defined in the stack, as all tasks will use the same container name.

### Description of changes

Add the new optional property `ContainerName` in the `ScheduledTaskImageProps`, so customer can use it to customize the containers names. If this property is undefined, so we will use `ScheduledContainer` as default value.

### Description of how you validated changes

added unit and integration test cases, and verified them.

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this issue Jun 10, 2024
@moelasmar
feat(ecs-patterns): allow custom container name for Scheduled ecs and…
e0d51cb 
… fargate tasks (aws#30357)

### Issue # (if applicable)

Closes aws#30281
Closes aws#27515

### Reason for this change

The customers have difficulties to find the correct logs for some scheduled task if they have multiple tasks defined in the stack, as all tasks will use the same container name.

### Description of changes

Add the new optional property `ContainerName` in the `ScheduledTaskImageProps`, so customer can use it to customize the containers names. If this property is undefined, so we will use `ScheduledContainer` as default value.

### Description of how you validated changes

added unit and integration test cases, and verified them.

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@NOUIY NOUIY mentioned this issue Jun 22, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this issue Jun 29, 2024
Open
This was referenced Jun 29, 2024
Open
Open
This was referenced Jul 12, 2024
Open
Open
This was referenced Jul 19, 2024
Open
Open
@NOUIY NOUIY mentioned this issue Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moelasmar moelasmar

Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@peterwoodworth @moelasmar @mrtngrbmn