-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ecs_patterns: add customname parameter to ScheduledFargateTaskImageOptions #27515
Comments
Hey, there are a number of similar reported FRs for our patterns constructs. Our patterns are opinionated, if you need fine control over the resources we suggest dropping down to the L2 constructs. That said, we can still accept this as a feature request, thanks for the ask |
… fargate tasks (#30357) ### Issue # (if applicable) Closes #30281 Closes #27515 ### Reason for this change The customers have difficulties to find the correct logs for some scheduled task if they have multiple tasks defined in the stack, as all tasks will use the same container name. ### Description of changes Add the new optional property `ContainerName` in the `ScheduledTaskImageProps`, so customer can use it to customize the containers names. If this property is undefined, so we will use `ScheduledContainer` as default value. ### Description of how you validated changes added unit and integration test cases, and verified them. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
… fargate tasks (aws#30357) ### Issue # (if applicable) Closes aws#30281 Closes aws#27515 ### Reason for this change The customers have difficulties to find the correct logs for some scheduled task if they have multiple tasks defined in the stack, as all tasks will use the same container name. ### Description of changes Add the new optional property `ContainerName` in the `ScheduledTaskImageProps`, so customer can use it to customize the containers names. If this property is undefined, so we will use `ScheduledContainer` as default value. ### Description of how you validated changes added unit and integration test cases, and verified them. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… fargate tasks (aws#30357) ### Issue # (if applicable) Closes aws#30281 Closes aws#27515 ### Reason for this change The customers have difficulties to find the correct logs for some scheduled task if they have multiple tasks defined in the stack, as all tasks will use the same container name. ### Description of changes Add the new optional property `ContainerName` in the `ScheduledTaskImageProps`, so customer can use it to customize the containers names. If this property is undefined, so we will use `ScheduledContainer` as default value. ### Description of how you validated changes added unit and integration test cases, and verified them. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the feature
At the moment for a ScheduledFargateTaskImageOptions a new task definition is created with an automatically generated name.
This names are quite difficult to read in the AWS web console.
Please add a parameter to assign a custom name to the newly created task definition.
Same thing is possible in aws_ecs.FargateTaskDefinition with parameter family.
Use Case
I have to create a long list of tasks with similar task definitions. The name created by ScheduledFargateTaskImageOptions are not readable and makes it difficult to distinguish them from each other
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.84.0
Environment details (OS name and version, etc.)
Amazon Linux 2
The text was updated successfully, but these errors were encountered: