-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsx: enable automatic backup settings for Lustre file system #30340
fsx: enable automatic backup settings for Lustre file system #30340
Comments
@mazyu36 Thanks for the PR. Looks like property Thanks, |
@ashishdhingra
Therefore, I think it would be preferable to address it either in #30207, which is adding the storage type, or in a separate PR. Please let me know if you have any other thoughts or suggestions. |
… system (#30343) ### Issue # (if applicable) Closes #30340. ### Reason for this change Current LustreFileSystem class does not support automatic backups. ### Description of changes Add properties equivalent to those of the L1 construct to the L2 construct. * [automaticBackupRetentionDays](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws%5C_fsx.CfnFileSystem.LustreConfigurationProperty.html#automaticbackupretentiondays) * [copyTagsToBackups](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws%5C_fsx.CfnFileSystem.LustreConfigurationProperty.html#copytagstobackups) * [dailyAutomaticBackupStartTime](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws%5C_fsx.CfnFileSystem.LustreConfigurationProperty.html#dailyautomaticbackupstarttime) Segregated the `dailyAutomaticBackupStartTime` as a class to enable its usage in another file system's L2 construct (for example, Ontap) in the future. ### Description of how you validated changes Add unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Describe the feature
In the L1 construct, automatic backup settings can be used for the Lustre file system. However, the LustreFileSystem class does not support automatic backups.
Use Case
To enable automatic backup settings
Proposed Solution
Add the following properties from the L1 LustreConfigurationProperty to the L2 LustreConfiguration:
Other Information
No response
Acknowledgements
CDK version used
2.143.0
Environment details (OS name and version, etc.)
All
The text was updated successfully, but these errors were encountered: