-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsx: hour validation in LustreMaintenanceTime is not correct #30341
Closed
Labels
@aws-cdk/aws-fsx
Related to Amazon FSx
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
Comments
1 task
mergify bot
pushed a commit
that referenced
this issue
May 27, 2024
…LustreMaintenanceTime` class. (#30342) ### Issue # (if applicable) Closes #30341 ### Reason for this change The `hour` property in the `LustreMaintenanceTime` class should be between 0 and 23. But no validation error occurs when it is set to 24. ### Description of changes In the validate method, I changed it so that an error is thrown when the hour is greater than 23, instead of when the hour is greater than 24. This allows a validation error to occur when the hour is set to 24. ### Description of how you validated changes Changed unit tests and add integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
atanaspam
pushed a commit
to atanaspam/aws-cdk
that referenced
this issue
Jun 3, 2024
…LustreMaintenanceTime` class. (aws#30342) ### Issue # (if applicable) Closes aws#30341 ### Reason for this change The `hour` property in the `LustreMaintenanceTime` class should be between 0 and 23. But no validation error occurs when it is set to 24. ### Description of changes In the validate method, I changed it so that an error is thrown when the hour is greater than 23, instead of when the hour is greater than 24. This allows a validation error to occur when the hour is set to 24. ### Description of how you validated changes Changed unit tests and add integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg
pushed a commit
to vdahlberg/aws-cdk
that referenced
this issue
Jun 10, 2024
…LustreMaintenanceTime` class. (aws#30342) ### Issue # (if applicable) Closes aws#30341 ### Reason for this change The `hour` property in the `LustreMaintenanceTime` class should be between 0 and 23. But no validation error occurs when it is set to 24. ### Description of changes In the validate method, I changed it so that an error is thrown when the hour is greater than 23, instead of when the hour is greater than 24. This allows a validation error to occur when the hour is set to 24. ### Description of how you validated changes Changed unit tests and add integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Jul 19, 2024
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
@aws-cdk/aws-fsx
Related to Amazon FSx
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
Describe the bug
The
validate
method in theLustreMaintenanceTime
checkshour
property between 0 and 24.aws-cdk/packages/aws-cdk-lib/aws-fsx/lib/maintenance-time.ts
Line 99 in 823cab3
But
hour
property should be between 0 and 23.The following is a quotation from the CloudFormation docs.
Expected Behavior
Should be validation error when
hour
property is set to24
.Current Behavior
No validation error when
hour
property is set to24
.But error occurs when deploy phase.
Reproduction Steps
Possible Solution
Change validate method like this.
Additional Information/Context
Even if you set the value to 24 for hour, it results in a deployment error, so in my understanding, the above change is not a breaking change.
CDK CLI Version
2.143.0
Framework Version
No response
Node.js Version
v20.6.0
OS
MacOS
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: