Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apprunner: support auto-scaling configuration management #30353

Closed
1 of 2 tasks
mazyu36 opened this issue May 27, 2024 · 3 comments · Fixed by #30358 or codu-code/codu#969 · May be fixed by NOUIY/aws-solutions-constructs#112, codu-code/codu#987 or gitafolabi/kreuzlaker#2
Closed
1 of 2 tasks

apprunner: support auto-scaling configuration management #30353

mazyu36 opened this issue May 27, 2024 · 3 comments · Fixed by #30358 or codu-code/codu#969 · May be fixed by NOUIY/aws-solutions-constructs#112, codu-code/codu#987 or gitafolabi/kreuzlaker#2
Labels
@aws-cdk/aws-apprunner Related to the apprunner package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/work-in-progress This PR is a draft and needs further work.

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 27, 2024

Describe the feature

AppRunner supports Auto-Scaling configuration management.
https://aws.amazon.com/about-aws/whats-new/2023/09/aws-app-runner-auto-scaling-management/

L1 Construct already supported, but current L2 Construct does not support.

Use Case

To use auto-scaling for AppRunner Service.

Proposed Solution

  • Add AutoScalingConfiguration class.
  • Add autoscaling property to the Service class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0

Environment details (OS name and version, etc.)

All
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 27, 2024
@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label May 27, 2024
@mazyu36 mazyu36 mentioned this issue May 28, 2024
Merged
1 task
@ashishdhingra ashishdhingra self-assigned this May 28, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 28, 2024
@ashishdhingra
Copy link
Contributor

Valid feature request for experimental AppRunner L2 construct.

@ashishdhingra ashishdhingra added p2 pr/work-in-progress This PR is a draft and needs further work. effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 28, 2024
@ashishdhingra ashishdhingra removed their assignment May 28, 2024
This was referenced Jun 1, 2024
Closed
Closed
@mergify mergify bot closed this as completed in #30358 Jun 21, 2024
mergify bot pushed a commit that referenced this issue Jun 21, 2024
@mazyu36
feat(apprunner): add AutoScalingConfiguration for AppRunner Service (#…
a598508 
…30358)

### Issue # (if applicable)

Closes #30353 .

### Reason for this change
At the moment, L2 Construct does not support a custom auto scaling configuration for the AppRunner Service.


### Description of changes
* Add `AutoScalingConfiguration` Class
* Add `autoScalingConfiguration` property to the `Service` Class



### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

sarangarav pushed a commit to sarangarav/aws-cdk that referenced this issue Jun 21, 2024
@mazyu36
feat(apprunner): add AutoScalingConfiguration for AppRunner Service (a…
279065a 
…ws#30358)

### Issue # (if applicable)

Closes aws#30353 .

### Reason for this change
At the moment, L2 Construct does not support a custom auto scaling configuration for the AppRunner Service.


### Description of changes
* Add `AutoScalingConfiguration` Class
* Add `autoScalingConfiguration` property to the `Service` Class



### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 added a commit to mazyu36/aws-cdk that referenced this issue Jun 22, 2024
@mazyu36
feat(apprunner): add AutoScalingConfiguration for AppRunner Service (a…
f09f8e2 
…ws#30358)

### Issue # (if applicable)

Closes aws#30353 .

### Reason for this change
At the moment, L2 Construct does not support a custom auto scaling configuration for the AppRunner Service.


### Description of changes
* Add `AutoScalingConfiguration` Class
* Add `autoScalingConfiguration` property to the `Service` Class



### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-apprunner Related to the apprunner package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
3 participants
@mazyu36 @aws-cdk-automation @ashishdhingra