Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepfunctions-tasks: support FLEX execution class for GlusStartJobRun #30533

Closed
1 of 2 tasks
mazyu36 opened this issue Jun 12, 2024 · 3 comments · Fixed by #30534 · 4 remaining pull requests
Closed
1 of 2 tasks

stepfunctions-tasks: support FLEX execution class for GlusStartJobRun #30533

mazyu36 opened this issue Jun 12, 2024 · 3 comments · Fixed by #30534 · 4 remaining pull requests
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jun 12, 2024

Describe the feature

Glue Job supports FLEX execution class.

This feature can be used by setting ExecutionClass in StartJobRun.

But current GlusStartJobRun class does not support it.

Use Case

To reduce job running cost by using FLEX class.

Proposed Solution

Add executionClass property.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0

Environment details (OS name and version, etc.)

all

@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2024
@mazyu36 mazyu36 changed the title stepfunctions-tasks: support execution class for glue job stepfunctions-tasks: support FLEX execution class for GlusStartJobRun Jun 12, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2024
@khushail khushail self-assigned this Jun 12, 2024
@khushail
Copy link
Contributor

Thanks @mazyu36 for submitting the request and PR contribution on adding this FLEX executionClass.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jun 12, 2024
@khushail khushail removed their assignment Jun 12, 2024
@khushail khushail added p3 and removed p2 labels Jun 12, 2024
@mergify mergify bot closed this as completed in #30534 Jun 20, 2024
mergify bot pushed a commit that referenced this issue Jun 20, 2024
…JobRun (#30534)

### Issue # (if applicable)

Closes #30533 

### Reason for this change
To support `FLEX` execution class for `GlusStartJobRun`.
By using `FLEX` class, you can reduce the cost of running Glue job.



### Description of changes
Add `execution class` to the `GlusStartJobRun` class.


### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

sarangarav pushed a commit to sarangarav/aws-cdk that referenced this issue Jun 21, 2024
…JobRun (aws#30534)

### Issue # (if applicable)

Closes aws#30533 

### Reason for this change
To support `FLEX` execution class for `GlusStartJobRun`.
By using `FLEX` class, you can reduce the cost of running Glue job.



### Description of changes
Add `execution class` to the `GlusStartJobRun` class.


### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 added a commit to mazyu36/aws-cdk that referenced this issue Jun 22, 2024
…JobRun (aws#30534)

### Issue # (if applicable)

Closes aws#30533 

### Reason for this change
To support `FLEX` execution class for `GlusStartJobRun`.
By using `FLEX` class, you can reduce the cost of running Glue job.



### Description of changes
Add `execution class` to the `GlusStartJobRun` class.


### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.