-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway API: integration timeout cannot be over 29 seconds #30539
Comments
I'll take care of it, thanks for the detailed issue 👍 |
@nmussy Thanks for the PR. |
Another issue #30550 related to timeout. |
|
1 similar comment
|
### Issue # (if applicable) Closes aws#30539. ### Reason for this change AWS , see [announcement](https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-api-gateway-integration-timeout-limit-29-seconds/) and [Amazon API Gateway quotas](https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html) ### Description of changes * Updated exception of `apigateway` `Integration` to only check the `timeout` lower bound * Added exception check of the `timeout` prop to `apigateway-v2` `WebSocketIntegration`, to match the `apigateway` v1 behavior * Implemented the `timeout` property to `apigateway-v2` `HttpIntegration` and its sub-integrations (`HttpAlbIntegration`, `HttpLambdaIntegration`, etc.) * Updated TSDoc ### Description of how you validated changes Updated unit and integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes aws#30539. ### Reason for this change AWS , see [announcement](https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-api-gateway-integration-timeout-limit-29-seconds/) and [Amazon API Gateway quotas](https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html) ### Description of changes * Updated exception of `apigateway` `Integration` to only check the `timeout` lower bound * Added exception check of the `timeout` prop to `apigateway-v2` `WebSocketIntegration`, to match the `apigateway` v1 behavior * Implemented the `timeout` property to `apigateway-v2` `HttpIntegration` and its sub-integrations (`HttpAlbIntegration`, `HttpLambdaIntegration`, etc.) * Updated TSDoc ### Description of how you validated changes Updated unit and integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Describe the bug
AWS API Gateway timeout limit for integrations was previously 29 seconds. There has been an update to allow increasing the Gateway integration timeouts past the previous limit. https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-api-gateway-integration-timeout-limit-29-seconds/
However, when implementing a Gateway API to Lambda, it seems that when synth'ing the stack, this seems to hit a validation error.
Expected Behavior
When configuring the Gateway API type (regional/private), timeout could be set over 29 seconds.
Current Behavior
When configuring the Gateway API, timeout cannot be over 29 seconds.
Error log when deploying/synth'ing
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.145.0
Framework Version
2.145.0
Node.js Version
20.14.0
OS
MacOS
Language
TypeScript
Language Version
No response
Other information
This issue came up when using
aws-solutions-constructs
. After quick look, it seemed to point to the Gateway API core package. Original issue reference here: awslabs/aws-solutions-constructs#1137,The text was updated successfully, but these errors were encountered: