-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-route53: Not able to retrieve Name Servers for fake-name due to it being imported.
CrossAccountZoneDelegationRecord delegatedZone
validation on NameServers blocks using Custom Resource to retrieve NameServers
#30600
aws-route53: Not able to retrieve Name Servers for fake-name due to it being imported.
CrossAccountZoneDelegationRecord delegatedZone
validation on NameServers blocks using Custom Resource to retrieve NameServers
#30600
Comments
This is a regression and therefore a p0. Updating the label here. |
delegatedZone
validation on NameServers blocks using Custom Resource to retrieve NameServersNot able to retrieve Name Servers for fake-name due to it being imported.
aws-route53: CrossAccountZoneDelegationRecord delegatedZone
validation on NameServers blocks using Custom Resource to retrieve NameServers
Not able to retrieve Name Servers for fake-name due to it being imported.
aws-route53: CrossAccountZoneDelegationRecord delegatedZone
validation on NameServers blocks using Custom Resource to retrieve NameServersNot able to retrieve Name Servers for fake-name due to it being imported.
CrossAccountZoneDelegationRecord delegatedZone
validation on NameServers blocks using Custom Resource to retrieve NameServers
|
1 similar comment
|
…time with imported `delegatedZone` (#30440)" (#30606) This reverts commit a3d9b10. ### Issue # (if applicable) Closes #30600. ### Reason for this change Reverting #30440 so that `cdk synth` succeed when using imported `delegatedZone` ### Description of changes Removed the `throw new Error()` ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Please add your +1 👍 to let us know you have encountered this
Status: RESOLVED
Overview:
Versions 2.145.0-2.147.0 will throw a synthesis error when passing an imported
delegatedZone
toroute53.CrossAccountZoneDelegationRecord
. For example, the following code will throw:Complete Error Message:
Workaround:
Pin the version of
aws-cdk-lib
to2.144.0
.Solution:
Related Issues:
Original Report
Describe the bug
The fix in #30440 is blocking users from using custom resource to retrieve the delegated zone name servers.
Expected Behavior
CDK should not throw error that blocks the user when the delegated zone is imported and does not have Name Servers information as users can use custom resource to retrieve the NS.
Current Behavior
CrossAccountZoneDelegationRecord throws when
delegatedZone
is imported.Reproduction Steps
Following code will throw the error in question:
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.146.0
Framework Version
No response
Node.js Version
20
OS
mac
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: