Partition endpoint test fixes (#1829)

* Fix partition tests due to updated endpoints file * Add changelog
aws · Jun 26, 2019 · ad2f5c7 · ad2f5c7
1 parent 2dd70c3
commit ad2f5c7
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 25 deletions.
diff --git a/.changes/nextrelease/partition_endpoint_test_fixes.json b/.changes/nextrelease/partition_endpoint_test_fixes.json
@@ -0,0 +1,7 @@
+[
+  {
+    "type": "feature",
+    "category": "Test",
+    "description": "Updated endpoints file with corresponding updated partition tests."
+  }
+]
diff --git a/src/data/endpoints.json b/src/data/endpoints.json
@@ -1110,13 +1110,6 @@
           "eu-west-1" : { },
           "eu-west-2" : { },
           "eu-west-3" : { },
-          "local" : {
-            "credentialScope" : {
-              "region" : "us-east-1"
-            },
-            "hostname" : "localhost:8000",
-            "protocols" : [ "http" ]
-          },
           "sa-east-1" : { },
           "us-east-1" : { },
           "us-east-1-fips" : {
@@ -1697,12 +1690,6 @@
       },
       "kms" : {
         "endpoints" : {
-          "ProdFips" : {
-            "credentialScope" : {
-              "region" : "ca-central-1"
-            },
-            "hostname" : "kms-fips.ca-central-1.amazonaws.com"
-          },
           "ap-east-1" : { },
           "ap-northeast-1" : { },
           "ap-northeast-2" : { },
@@ -2965,13 +2952,6 @@
           "eu-west-1" : { },
           "eu-west-2" : { },
           "eu-west-3" : { },
-          "local" : {
-            "credentialScope" : {
-              "region" : "us-east-1"
-            },
-            "hostname" : "localhost:8000",
-            "protocols" : [ "http" ]
-          },
           "sa-east-1" : { },
           "us-east-1" : { },
           "us-east-1-fips" : {
@@ -3656,6 +3636,11 @@
           "cn-northwest-1" : { }
         }
       },
+      "support" : {
+        "endpoints" : {
+          "aws-cn-global" : { }
+        }
+      },
       "swf" : {
         "endpoints" : {
           "cn-north-1" : { },

diff --git a/src/data/endpoints.json.php b/src/data/endpoints.json.php
diff --git a/tests/ClientResolverTest.php b/tests/ClientResolverTest.php
@@ -763,7 +763,7 @@ public function partitionReturnProvider()
             [
                 ['service' => 'dynamodb', 'region' => 'local'] + $invocationArgs,
                 'signing_region',
-                'us-east-1',
+                'local',
             ],
         ];
     }

diff --git a/tests/Endpoint/PartitionEndpointProviderTest.php b/tests/Endpoint/PartitionEndpointProviderTest.php
@@ -126,9 +126,9 @@ public function endpointProvider()
             [
                 ['region' => 'local', 'service' => 'dynamodb', 'scheme' => 'http'],
                 [
-                    'endpoint' => 'http://localhost:8000',
+                    'endpoint' => 'http://dynamodb.local.amazonaws.com',
                     'signatureVersion' => 'v4',
-                    'signingRegion' => 'us-east-1',
+                    'signingRegion' => 'local',
                     'signingName' => 'dynamodb',
                 ],
             ],
@@ -465,7 +465,7 @@ public function knownEndpointProvider()
             [$partitions, 'eu-west-1', 'swf', 'swf.eu-west-1.amazonaws.com'],
             [$partitions, 'eu-west-1', 'workspaces', 'workspaces.eu-west-1.amazonaws.com'],
             [$partitions, 'fips-us-gov-west-1', 's3', 's3-fips-us-gov-west-1.amazonaws.com'],
-            [$partitions, 'local', 'dynamodb', 'localhost:8000'],
+            [$partitions, 'local', 'dynamodb', 'dynamodb.local.amazonaws.com'],
             [$partitions, 's3-external-1', 's3', 's3-external-1.amazonaws.com'],
             [$partitions, 'sa-east-1', 'autoscaling', 'autoscaling.sa-east-1.amazonaws.com'],
             [$partitions, 'sa-east-1', 'cloudformation', 'cloudformation.sa-east-1.amazonaws.com'],