Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 stream wrapper write empty files #1744

Merged
merged 4 commits into from
Mar 7, 2019

Conversation

howardlopez
Copy link
Contributor

@howardlopez howardlopez commented Mar 6, 2019

  • Updates the S3 stream wrapper to be able to write empty files for PHP 7+

Fixes #1724

@howardlopez howardlopez changed the title Stream wrapper fixes S3 stream wrapper write empty files Mar 6, 2019
@howardlopez howardlopez closed this Mar 7, 2019
@howardlopez howardlopez reopened this Mar 7, 2019
@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #1744 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1744      +/-   ##
============================================
+ Coverage     94.23%   94.25%   +0.01%     
- Complexity     2998     3000       +2     
============================================
  Files           178      178              
  Lines          8085     8089       +4     
============================================
+ Hits           7619     7624       +5     
+ Misses          466      465       -1
Impacted Files Coverage Δ Complexity Δ
src/S3/StreamWrapper.php 97.45% <100%> (+0.31%) 144 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875786b...56e1be2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants