Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix endpoint path removal #1795

Merged
merged 2 commits into from
May 22, 2019
Merged

fix endpoint path removal #1795

merged 2 commits into from
May 22, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented May 21, 2019

Resolves #1730

Removes leading slash of relative path when resolving URIs. This preserves the path when a custom endpoint with a path is specified for a client.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #1795 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1795      +/-   ##
============================================
- Coverage     94.19%   94.17%   -0.02%     
- Complexity     3070     3072       +2     
============================================
  Files           180      180              
  Lines          8210     8213       +3     
============================================
+ Hits           7733     7735       +2     
- Misses          477      478       +1
Impacted Files Coverage Δ Complexity Δ
src/Api/Serializer/RestSerializer.php 95.04% <66.66%> (-0.87%) 54 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759a565...dcfbfa0. Read the comment docs.

@srchase srchase requested a review from howardlopez May 21, 2019 23:23
@srchase srchase merged commit 880f442 into aws:master May 22, 2019
@srchase srchase deleted the fix-endpoint-path branch May 22, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApiGatewayManagementApiClient: Endpoint stage gets removed from URI
3 participants