Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type-hint for exception type change #2888

Closed
wants to merge 1 commit into from

Conversation

rrehbein
Copy link

Description of changes:

Update type-hint for exception wrapper to allow for other php throwable types.

Fixes:

Aws\Exception\AwsException::__construct(): Argument #4 ($previous) must be of type ?Exception, Error given, called in vendor/aws/aws-sdk-php/src/WrappedHttpHandler.php on line 196

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yenfryherrerafeliz
Copy link
Contributor

Hi @rrehbein, thanks for this contribution. I do not see any issue on this change, however, may I know if you are facing any specific problem that this PR will solve?, if so, can you please provide any details for reproducing it?, or even better, could you please open an issue here. By doing this we can have a more clear reason for merging this PR.

Thanks!

@rrehbein
Copy link
Author

Sorry at this time I don't have the details of the error that errored in the error handler. I'll see if I can capture more details.

@yenfryherrerafeliz
Copy link
Contributor

Hi @rrehbein, I will close this PR for now. However, if this is still something you think is needed in the AWS SDK for PHP, please feel free of opening a new PR base on the current branch, and make sure you provide an issue associated with it, with a reproducible code so we can understand why the suggested change is needed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants