Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disabling node version check with environment variable #3817

Closed
1 of 2 tasks
christophgysin opened this issue Nov 1, 2022 · 2 comments · Fixed by #3841
Closed
1 of 2 tasks

Support disabling node version check with environment variable #3817

christophgysin opened this issue Nov 1, 2022 · 2 comments · Fixed by #3841
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@christophgysin
Copy link

christophgysin commented Nov 1, 2022 •
edited
Loading

Describe the feature

When running untested versions of node, I get a large warning message, e.g.

$ cdk version
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!                                                                                  !!
!!  This software has not been tested with node v19.0.0.                            !!
!!  You may to encounter runtime issues, and should switch to a supported release.  !!
!!                                                                                  !!
!!  This software is currently running on node v19.0.0.                             !!
!!  As of the current release of this software, supported node releases are:        !!
!!  - ^18.0.0 (Planned end-of-life: 2025-04-30)                                     !!
!!  - ^16.3.0 (Planned end-of-life: 2023-09-11)                                     !!
!!  - ^14.6.0 (Planned end-of-life: 2023-04-30)                                     !!
!!                                                                                  !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

While I understand the reason for the warning, I would like a way to tell JSII that I know what I'm doing and not display a warning every single time.

Use Case

Running aws-cdk on the default version that ships with ArchLinux.

Proposed Solution

e.g. by setting an environment variable:

export JSII_DISABLE_NODE_VERSION_CHECK=1

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.48.0

Environment details (OS name and version, etc.)

Linux 6.0.6-arch1-1
@christophgysin christophgysin added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2022
@christophgysin
Copy link
Author

Related to #3171

RomainMuller added a commit that referenced this issue Nov 15, 2022
@RomainMuller
feat: allow silencing @jsii/check-node warnings
79572af 
Allows silencing @jsii/check-node warnings when the runtime is not
End-of-Life, so that users who know what they are doing can suppress
the extraneous output.

This is particularly useful for new Node releases that are un-tested,
but can typically be expected to work, or known broken releases that
happen to work for a given use-case that is carefully crafted to avoid
the known issues; but is also possible for deprecated node releases.

Messages about using end-of-life releases are intentionally not
suppressible.

Also updated the message for un-tested and known-broken releases to
better frame the fact that these might work fine, and urge users to
retry using a known supported release before they file a bug report.

Fixes #3817
Fixes #3171
@RomainMuller RomainMuller mentioned this issue Nov 15, 2022
Merged
RomainMuller added a commit that referenced this issue Nov 24, 2022
@RomainMuller
feat(check-node): allow silencing @jsii/check-node warnings (#3841)
880dbcc 
Allows silencing @jsii/check-node warnings when the runtime is not End-of-Life, so that users who know what they are doing can suppress the extraneous output.

This is particularly useful for new Node releases that are un-tested, but can typically be expected to work, or known broken releases that happen to work for a given use-case that is carefully crafted to avoid the known issues; but is also possible for deprecated node releases.

Messages about using end-of-life releases are intentionally not suppressible.

Also updated the message for un-tested and known-broken releases to better frame the fact that these might work fine, and urge users to retry using a known supported release before they file a bug report.

Additionally adds testing for Node 19.x.

Fixes #3817
Fixes #3171
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(check-node): allow silencing @jsii/check-node warnings aws/jsii
1 participant
@christophgysin