Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.tsbuildinfo to auto-generated .npmignore file #3978

Closed
1 of 2 tasks
m-radzikowski opened this issue Feb 24, 2023 · 2 comments
Closed
1 of 2 tasks

Add *.tsbuildinfo to auto-generated .npmignore file #3978

m-radzikowski opened this issue Feb 24, 2023 · 2 comments
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@m-radzikowski
Copy link

Describe the feature

If I'm not mistaken, the tsconfig.tsbuildinfo file generated during the jsii build should not be part of the output package.

If the .npmignore file does not exist, the jsii-pacmak generates it automatically. It includes ignores for *.ts and tsconfig.json, but not tsconfig.tsbuildinfo.

Use Case

Following the documentation, I ended up with a bundle file containing >2 MB tsconfig.tsbuildinfo file, being 90% of the package size.

Proposed Solution

Add *.tsbuildinfo here:

excludePattern(
'Exclude typescript source and config',
'*.ts',
'tsconfig.json',
);

Other Information

jsii and jsii-pacmak v1.75.0

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Environment details (OS name and version, etc.)

any

@m-radzikowski m-radzikowski added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 24, 2023
@NextThread
Copy link
Contributor

hi, added this feature

mergify bot pushed a commit that referenced this issue Nov 14, 2023
#3978 
Added *.tsbuildinfo to auto-generated .npmignore file
@mrgrain mrgrain closed this as completed Feb 22, 2024
Copy link
Contributor

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants