Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii-pacmak): parsing arguments in non-strict mode #4068

Merged
merged 2 commits into from
Apr 26, 2023
Merged

feat(jsii-pacmak): parsing arguments in non-strict mode #4068

merged 2 commits into from
Apr 26, 2023

Conversation

huyphan
Copy link
Contributor

@huyphan huyphan commented Apr 24, 2023

Some targets support extra target-specific arguments so users can customize the behavior of the build tools. For example, the Java target allows users to customize the mvn CLI behaviour with --mvn-* parameters. However the jsi-pacmak CLI is blocking this feature because it is using strict mode when parsing arguments. This change lifts that gate.

This address #3465


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Some targets support extra target-specific arguments so users can
customize the behavior of the build tools. For example, the Java target
allows users to customize the `mvn` CLI behaviour with `--mvn-*` parameters.
However the `jsi--pacmak` CLI is blocking this feature because it is
using strict mode when parsing argument. This change lifts that gate.
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the drawback of silently accepting typo'd flags and arguments, which is a little unfortunate... But I guess the feature is worth the trade-off here...

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Apr 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

Merging (with squash)...

@mergify mergify bot merged commit 3d49d6f into aws:main Apr 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants