Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to python 3.8 #4239

Merged
merged 5 commits into from
Nov 2, 2023
Merged

chore: switch to python 3.8 #4239

merged 5 commits into from
Nov 2, 2023

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Aug 17, 2023

Python 3.7 has been end-of-life since 2023-06-27, and an
increasing amount of our dependencies are dropping support for it as a
consequence.

We introduced a warning to users that are still using Python 3.7 with
release v1.86.0 around August 1, 2023.

We are now effectively dropping support for Python 3.7.

Related: 0ef7ace

BREAKING CHANGE: jsii-pacmak and the libraries it generates for Python
targets now require a minimum Python version of 3.8, instead of 3.7
previously. We recommend users upgrade to the latest supported Python
release (Python 3.11).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 17, 2023
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the minimum version of python that jsii supports? I'm not sure what that is, it's not transparent in the jsii or CDK docs. Can we answer that before making a decision on this? We should be testing with the minimum version of python that is supported.

@corymhall corymhall closed this Aug 18, 2023
@corymhall corymhall reopened this Aug 18, 2023
@corymhall corymhall added the pr/do-not-merge This PR should not be merged at this time. label Aug 18, 2023
@corymhall
Copy link
Contributor Author

⚠️ This PR should remain labeled with pr/do-not-merge at least until 2023-09-01 (at which point it'll have been a full month since we released the first version of jsii that emits a deprecation warning to users still on Python 3.7).

@TheRealAmazonKendra TheRealAmazonKendra removed the pr/do-not-merge This PR should not be merged at this time. label Oct 12, 2023
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 2, 2023
Copy link
Contributor

mergify bot commented Nov 2, 2023

Merging (with squash)...

@mergify mergify bot merged commit 087ff24 into main Nov 2, 2023
33 checks passed
@mergify mergify bot deleted the corymhall/build-python3.8 branch November 2, 2023 21:56
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Nov 2, 2023
mikewrighton added a commit that referenced this pull request Nov 6, 2023
mergify bot pushed a commit that referenced this pull request Nov 6, 2023
This reverts commit 087ff24.



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
mrgrain pushed a commit that referenced this pull request Nov 14, 2023
Python 3.7 has been end-of-life since 2023-06-27, and an
increasing amount of our dependencies are dropping support for it as a
consequence.

We introduced a warning to users that are still using Python 3.7 with
release v1.86.0 around August 1, 2023.

We are now effectively dropping support for Python 3.7.

Related: 0ef7ace

BREAKING CHANGE: jsii-pacmak and the libraries it generates for Python
targets now require a minimum Python version of 3.8, instead of 3.7
previously. We recommend users upgrade to the latest supported Python
release (Python 3.11).

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
Python 3.7 has been end-of-life since 2023-06-27, and an increasing amount of our dependencies are dropping support for it as a consequence.

We introduced a warning to users that are still using Python 3.7 with release v1.86.0 around August 1, 2023.

We are now effectively dropping support for Python 3.7.

Related: 0ef7ace

Re-roll of #4239, which was reverted because the build & release pipeline failed. After some investigation this was because the job used a superchain image with python3.7. However after this change a minimum version of python 3.8 is required.

BREAKING CHANGE: jsii-pacmak and the libraries it generates for Python targets now require a minimum Python version of 3.8, instead of 3.7 previously. We recommend users upgrade to the latest supported Python release (Python 3.11).

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants