Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go-runtime): include error message when wrapping a @jsii/kernel.Fault #4275

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

bmoffatt
Copy link
Contributor

I ran into this error message when developing a JSII compatible construct.

panic: JsiiError: @jsii/kernel.Fault

Including the de-serialized error message into the wrapped error helped me debug that I was missing the .jsii file in my distribution! (eg: I needed to add ".jsii" to the "files" list in my construct's package.json)

panic: JsiiError: @jsii/kernel.Fault Error for package tarball /var/folders/<redacted>.tgz: Expected to find .jsii file in /var/folders/<redacted>/node_modules/<redacted>, but no such file found

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2023

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@bmoffatt bmoffatt changed the title Include the error message when the go runtime observes a @jsii/kernel.Fault feat(go-runtime): Include the error message when wrapping a @jsii/kernel.Fault Sep 22, 2023
mrgrain
mrgrain previously approved these changes Dec 15, 2023
@mrgrain mrgrain changed the title feat(go-runtime): Include the error message when wrapping a @jsii/kernel.Fault feat(go-runtime): include the error message when wrapping a @jsii/kernel.Fault Dec 15, 2023
@mrgrain mrgrain changed the title feat(go-runtime): include the error message when wrapping a @jsii/kernel.Fault feat(go-runtime): include error message when wrapping a @jsii/kernel.Fault Dec 15, 2023
Copy link
Contributor

mergify bot commented Dec 15, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Dec 15, 2023
Copy link
Contributor

mergify bot commented Dec 15, 2023

Merging (with squash)...

@mergify mergify bot dismissed mrgrain’s stale review December 15, 2023 11:23

Pull request has been modified.

Copy link
Contributor

mergify bot commented Dec 15, 2023

Merging (with squash)...

@mergify mergify bot merged commit c6eb62a into aws:main Dec 15, 2023
28 checks passed
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants