fix(kernel): invokeBinScript fails when using symlinked cache #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
commented
Nov 13, 2023
| @@ -2,11 +2,16 @@ | |||
|
|
|||
| /* eslint-disable no-console */ | |||
|
|
|||
| import * as calcLib from '@scope/jsii-calc-lib'; | |||
There was a problem hiding this comment.
This was the previously untested scenario.
madeline-k
approved these changes
Nov 13, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
mrgrain
added a commit
that referenced
this pull request
Jan 3, 2024
This was previously attempted to fix in #4324 While the above fix resolves issues with dependencies, it causes failures when the binary is shelling out to other node processes. This is due to the intrusive and indiscriminate overloading of NODE_OPTIONS, which will forcibly apply to any child processes as well. While in theory adding the symlink flags should not be an issue, this seems to trigger a bug in node: nodejs/node#41000 tl;dr this all sucks very much and we are now just disabling the runtime cache for binaries.
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
This was previously attempted to fix in #4324 While the above fix resolves issues with dependencies, it causes failures when the binary is shelling out to other node processes. This is due to the intrusive and indiscriminate overloading of NODE_OPTIONS, which will forcibly apply to any child processes as well. While in theory adding the symlink flags should not be an issue, this seems to trigger a bug in node: nodejs/node#41000 tl;dr this all sucks very much and we are now just disabling the runtime cache for binaries. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking bin scripts from jsii packages would fail if the symlinked cache was enabled and the invoked script depended on an other package. The reason for this was that scripts were only invoked with
--preserve-symlinks, however for "main scripts" (like standalone binaries), we also need to call--preserve-symlinks-mainon the node process.Note this cannot be tested in the kernel package itself, as it's not possible to invoke the test process with the correct options.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.