fix(superchain): installed setuptools is an unsupported version #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
commented
Nov 15, 2023
| @@ -65,7 +65,7 @@ beforeAll(async () => { | |||
| [ | |||
| '[tool.pyright]', | |||
| 'defineConstant = { DEBUG = true }', | |||
| 'pythonVersion = "3.7"', | |||
| 'pythonVersion = "3.8"', | |||
There was a problem hiding this comment.
This was just a miss in the python3.8 PR
mrgrain
commented
Nov 15, 2023
mrgrain
changed the title
mrgrain
force-pushed
the
mrgrain/fix/setuptools-too-old
branch
from
b9165d6
to
e4fc1ad
Compare
mrgrain
commented
Nov 15, 2023
| ${PYTHON} -m pip install --upgrade pip~=22.1 twine~=4.0 | ||
|
|
||
| # Note the venv is not used by the jsii-pacmak commands | ||
| ${PYTHON} -m pip install --upgrade pip>=23.3.1 setuptools>=68.2.2 wheel>=0.41.3 twine~=4.0 |
There was a problem hiding this comment.
The venv isn't actually used to run pacmak for some reason. So this change doesn't have any effect on the failure in question. I could revert it, but feels better to also require an explicit version here.
mrgrain
commented
Nov 15, 2023
superchain/Dockerfile
Outdated
| @@ -171,7 +171,7 @@ RUN apt-get update | |||
| && apt-get -y install python3-dev python3-pip python3-venv \ | |||
| && coercepip='--break-system-packages' \ | |||
| && if [[ ${DEBIAN_VERSION} == "buster" || ${DEBIAN_VERSION} == "bullseye" ]]; then coercepip=''; fi \ | |||
| && python3 -m pip install ${coercepip} pipx \ | |||
| && python3 -m pip install ${coercepip} pipx "pip>=23.3.1" "setuptools>=68.2.2" "wheel>=0.41.3" \ | |||
There was a problem hiding this comment.
This is the change!
rix0rrr
approved these changes
Nov 15, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the jsii-pacmak build tests inside a
jsii/superchain:1-bullseye-slim-nightlycontainer would fail with "invalid command 'bdist_wheel'".This was due to an outdated & unsupported (by jsii) version of
setuptoolsbeing present in the image.In #4219 we inadvertently removed installing a newer version of
setuptools.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.