Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii-pacmak): show custom pack-command in timer label #4392

Merged
merged 3 commits into from
Jan 9, 2024
Merged

fix(jsii-pacmak): show custom pack-command in timer label #4392

merged 3 commits into from
Jan 9, 2024

Conversation

gmeligio
Copy link
Contributor

@gmeligio gmeligio commented Jan 8, 2024

Currently 'npm pack' is shown in the logs regardless of the custom command. Like in:

[jsii-pacmak] [INFO] Packaged. npm pack (42.4s) | cleanup (3.8s) | load jsii (0.0s) | js (0.0s)

This behaviour is confusing because it leaves doubt about which command was actually applied. This PR passes the value of the pack-command option to the timer label.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmeligio gmeligio changed the title fix(jsii-pacmak: pass pack-command in timer label fix(jsii-pacmak): pass pack-command in timer label Jan 8, 2024
@gmeligio gmeligio changed the title fix(jsii-pacmak): pass pack-command in timer label fix(jsii-pacmak): show custom pack-command in timer label Jan 9, 2024
mrgrain
mrgrain previously approved these changes Jan 9, 2024
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you!

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Jan 9, 2024
@mrgrain
Copy link
Contributor

mrgrain commented Jan 9, 2024

@gmeligio Fails with formatting errors. Please run the build commands locally to ensure linting passes. Thanks.

@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Jan 9, 2024
@mrgrain mrgrain self-requested a review January 9, 2024 11:39
@mrgrain mrgrain dismissed their stale review January 9, 2024 11:39

needs linting fix

@gmeligio
Copy link
Contributor Author

gmeligio commented Jan 9, 2024

Thank you, @mrgrain, for the review. I ran locally yarn lint:fix and fixed eslint errors.

Copy link
Contributor

mergify bot commented Jan 9, 2024

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 9, 2024
Copy link
Contributor

mergify bot commented Jan 9, 2024

Merging (with squash)...

Copy link
Contributor

mergify bot commented Jan 9, 2024

Merging (with squash)...

@mergify mergify bot merged commit 3c1b4b1 into aws:main Jan 9, 2024
28 checks passed
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants