Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reflect): additional type predicates for isXyzType methods #4491

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 26, 2024

This helps downstream consumers to not have to add type annotations themselves when using these methods.

Before:

function needsInterface(type: reflect.InterfaceType) {}

if (type.isInterfaceType()) {
  needsInterface(type as reflect.InterfaceType);
}

After:

function needsInterface(type: reflect.InterfaceType) {}

if (type.isInterfaceType()) {
  needsInterface(type);
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

Merging (with squash)...

@mergify mergify bot merged commit 459481f into main Apr 26, 2024
39 checks passed
@mergify mergify bot deleted the mrgrain/reflect/fix/improved-type-predicates branch April 26, 2024 10:05
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants