Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6055
Description
This fixes the volume size string validation that should have already been performed to ensure that the resource value must be one of
T
,Ti
,G
, orGi
. You could bypass this check by specifying an integer; however, etcd would store this value as a string somewhere down the line which would cause us to fail to delete the EC2NodeClass.There's an open issue against
controller-gen
to try and dig deeper into what causes the integer to be able to circumvent this validation but then pass through the validation later, causing it to fail.How was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.