fix(aws-sns-sqs): fix circular dependency error in aws-sns-sqs (#1122)

* First Commit * All code changes, no docs yet * Refresh test * Updated documentation * Remove .js files * Update gitignore to ignore new test folder .js files * Update minimal deployment and integ tests to get access to new keys * Move CheckBooleanWithDefault() to utils.ts
awslabs · May 24, 2024 · 2366272 · 2366272
1 parent 55fca43
commit 2366272
Show file tree

Hide file tree

Showing 161 changed files with 15,956 additions and 1,368 deletions.
diff --git a/...utions-constructs/aws-s3-sns/test/integ.s3sns-newTopicFromProps.js.snapshot/manifest.json b/...utions-constructs/aws-s3-sns/test/integ.s3sns-newTopicFromProps.js.snapshot/manifest.json
@@ -66,7 +66,7 @@
         "validateOnSynth": false,
         "assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
         "cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
-        "stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/7be517f6dafbc09907a487548d47a37edc90275c9528176d77785fc210216042.json",
+        "stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/4f8a147fe5b64ace963b3c5437b4d2ca40626d3bd489c22bae586bde31f8faf7.json",
         "requiresBootstrapStackVersion": 6,
         "bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
         "additionalDependencies": [
@@ -133,7 +133,10 @@
         "/s3sns-newTopicFromProps/test-s3-sns/SnsTopic/Resource": [
           {
             "type": "aws:cdk:logicalId",
-            "data": "tests3snsSnsTopicF02F6BD0"
+            "data": "tests3snsSnsTopicF02F6BD0",
+            "trace": [
+              "!!DESTRUCTIVE_CHANGES: WILL_REPLACE"
+            ]
           }
         ],
         "/s3sns-newTopicFromProps/test-s3-sns/SnsTopic/Policy/Resource": [
@@ -183,15 +186,6 @@
             "type": "aws:cdk:logicalId",
             "data": "CheckBootstrapVersion"
           }
-        ],
-        "tests3snsEncryptionKey6C553584": [
-          {
-            "type": "aws:cdk:logicalId",
-            "data": "tests3snsEncryptionKey6C553584",
-            "trace": [
-              "!!DESTRUCTIVE_CHANGES: WILL_DESTROY"
-            ]
-          }
         ]
       },
       "displayName": "s3sns-newTopicFromProps"

diff --git a/...s3-sns/test/integ.s3sns-newTopicFromProps.js.snapshot/s3sns-newTopicFromProps.assets.json b/...s3-sns/test/integ.s3sns-newTopicFromProps.js.snapshot/s3sns-newTopicFromProps.assets.json
@@ -14,15 +14,15 @@
         }
       }
     },
-    "7be517f6dafbc09907a487548d47a37edc90275c9528176d77785fc210216042": {
+    "4f8a147fe5b64ace963b3c5437b4d2ca40626d3bd489c22bae586bde31f8faf7": {
       "source": {
         "path": "s3sns-newTopicFromProps.template.json",
         "packaging": "file"
       },
       "destinations": {
         "current_account-current_region": {
           "bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
-          "objectKey": "7be517f6dafbc09907a487548d47a37edc90275c9528176d77785fc210216042.json",
+          "objectKey": "4f8a147fe5b64ace963b3c5437b4d2ca40626d3bd489c22bae586bde31f8faf7.json",
           "assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
         }
       }

diff --git a/...-sns/test/integ.s3sns-newTopicFromProps.js.snapshot/s3sns-newTopicFromProps.template.json b/...-sns/test/integ.s3sns-newTopicFromProps.js.snapshot/s3sns-newTopicFromProps.template.json
@@ -417,13 +417,13 @@
   "tests3snsSnsTopicF02F6BD0": {
    "Type": "AWS::SNS::Topic",
    "Properties": {
+    "DisplayName": "new-topic-from-props",
     "KmsMasterKeyId": {
      "Fn::GetAtt": [
       "tests3snstests3snsKey1D741F34",
       "Arn"
      ]
-    },
-    "TopicName": "new-topic-from-props"
+    }
    }
   },
   "tests3snsSnsTopicPolicyBB44DF16": {