Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Pattern: aws-sns-sqs #24

Closed
hnishar opened this issue Jul 27, 2020 · 2 comments · Fixed by #48
Closed

New Pattern: aws-sns-sqs #24

hnishar opened this issue Jul 27, 2020 · 2 comments · Fixed by #48
Assignees
@danielmatuki
Labels
feature-request A feature should be added or improved

Comments

@hnishar
Copy link
Contributor

hnishar commented Jul 27, 2020

Add your +1 👍 to help us prioritize

Overview:

This AWS Solutions Construct implements an Amazon SNS Topic connected to an Amazon SQS queue.

User provided props for the construct:

  • Either an existing instances of sns.Topic or sns.TopicProps to deploy new SNS topic
  • Either an existing instances of sqs.Queue or sqs.QueueProps to deploy new SQS queue
  • Optional enableEncryption to encrypt the SNS topic (default: true)
  • Optional encryptionKey user provided encryption key
  • Optional deployDeadLetterQueue to deploy the DLQ (default: true)
  • Optional deadLetterQueueProps for the DLQ

Default settings

Out of the box implementation of the Construct without any override will set the following defaults:

Amazon SNS Topic

  • Enable server-side encryption forSNS Topic using Customer managed KMS Key

Amazon SQS Queue

  • Configure least privilege access permissions for SQS Queue
  • Deploy SQS dead-letter queue for the source SQS Queue.
  • Enable server-side encryption for source SQS Queue using AWS Managed KMS Key.
@hnishar hnishar added the feature-request A feature should be added or improved label Jul 27, 2020
@danielmatuki
Copy link
Contributor

Hi @hnishar I'm available to contribute to implement this new pattern.

@hnishar
Copy link
Contributor Author

hnishar commented Aug 11, 2020

Awesome! Thanks for reaching out and helping us out!

@hnishar hnishar added the in-progress This issue is being actively worked on label Aug 11, 2020
danielmatuki added a commit to danielmatuki/aws-solutions-constructs that referenced this issue Aug 25, 2020
@danielmatuki
feat(aws-sns-sqs): New aws-sns-sqs pattern implementation
ccd1d9c 
closes awslabs#24
@danielmatuki danielmatuki mentioned this issue Aug 25, 2020
Merged
hnishar pushed a commit that referenced this issue Aug 28, 2020
@danielmatuki
feat(aws-sns-sqs): New aws-sns-sqs pattern implementation (#48)
58f54de 
* feat(aws-sns-sqs): New aws-sns-sqs pattern implementation

closes #24

* fix(aws-sns-sqs): Update aws-sns-sqs package configuration to utilize latest cdk construct version 1.60.0

* fix(aws-sns-sqs): Update managed KMS key integration test to utilize a KMS key with rotation to perform SQS encryption.

* fix(aws-sns-sqs): code review changes for new aws-sns-sqs construct

* fix(aws-sns-sqs): code review changes for new aws-sns-sqs construct
@gockle gockle mentioned this issue Sep 9, 2020
Closed
@hnishar hnishar removed the in-progress This issue is being actively worked on label Oct 16, 2020
aws-solutions-constructs-team added a commit that referenced this issue Mar 17, 2023
@aws-solutions-constructs-team
Merge pull request #24 from aws-solutions-constructs-team/bump/2.34.0
6923daf 
chore(release): 2.34.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmatuki danielmatuki

Labels
feature-request A feature should be added or improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-sns-sqs): New aws-sns-sqs pattern implementation danielmatuki/aws-solutions-constructs
2 participants
@hnishar @danielmatuki