Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cloudfront-s3): do not create s3 access log bucket for cf log bucket when an existing bucket is provided #1052

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

biffgaut
Copy link
Contributor

Description of changes:
In this situation:

  const cfS3AccessLogBucket = new s3.Bucket(stack, 'cf-s3-access-logs');
  new CloudFrontToS3(stack, 'test-cloudfront-s3', {
    cloudFrontLoggingBucketProps: {
      serverAccessLogsBucket: cfS3AccessLogBucket
    }
  });

The construct will still create an S3 Access Log bucket for the CF log bucket. The provided bucket is ignored. What should happen is that the provided bucket is configured to accept the logs and no additional bucket is created.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 7eebd22
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@georgebearden georgebearden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@biffgaut biffgaut merged commit a54a318 into main Jan 19, 2024
8 checks passed
@biffgaut biffgaut deleted the AcceptLogBucket branch January 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants