T047 - Fix CloudWatch Log Policy Size in Step Functions construct #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
hnishar
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: T047 (internal)
Description of changes:
Log groups used by Step Functions must start with /aws/vendedlog/states or the policy generated to access the logs is too long. But each log file must have a unique name. Formerly we used to let CFN assign a random name, but that stopped working in the past 6 months. We can't instruct CFN to create a random name with a fixed prefix, so the PR creates a unique, but not random, name for each CloudWatch Logs group using a very similar method to the CDK - concatenating a portion of all the IDs in the construct tree and appending a hash created using all of the IDs in the construct tree.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.