feat (cloudfront-to-*): Add optional parameter cloudfront.ResponseHeadersPolicyProps #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adersPolicyProps to CloudFrontToS3Props, CloudFrontToMediaStoreProps, CloudFronToApiGatewayProps
tbelmega
requested review from
biffgaut,
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
|
P.S.: I added a missing / in DEVELOPER_GUIDE.md |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
requested changes
Nov 28, 2022
source/patterns/@aws-solutions-constructs/aws-cloudfront-apigateway-lambda/README.md
Outdated
Show resolved
Hide resolved
.../@aws-solutions-constructs/aws-cloudfront-apigateway/test/test.cloudfront-apigateway.test.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/core/lib/cloudfront-distribution-defaults.ts
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/core/lib/cloudfront-distribution-helper.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/core/lib/cloudfront-distribution-helper.ts
Outdated
Show resolved
Hide resolved
biffgaut
reviewed
Nov 28, 2022
…havior into input-validation.ts
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…ityHeaders in input-validation.ts
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
approved these changes
Dec 1, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added an additional optional parameter to the constructs CloudFrontToS3, CloudFrontToMediaStore, CloudFrontToApiGateway, CloudFrontToApiGatewayLambda.
The parameter allows the user of the construct to pass in a cloudfront.ResponseHeadersPolicyProps. If present, it will cause the constructs to create a ResponseHeadersPolicy.
This is particularly useful to create its own set of Security Header as demonstrated in the unit tests/integration test.
If ResponseHeadersPolicyProps with a SecurityHeadersBehavior attribute are passen to the Construct, the existing parameter setHttpSecurityHeaders has to be set to false. Otherwise the Construct will throw a validation error.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.