You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST /api/pipeline ---> POST /api/pipeline/CreatePipeline
GET /api/pipeline ---> GET /api/pipeline/ListPipelines
GET /api/pipeline/<id> ---> GET /api/pipeline/GetPipeline?id=xxx
Interface parameters, for example:
The GET method only uses query to pass parameters
The POST/PUT/DELETE method only uses body to pass parameters
Define Request and Response objects for all API, shared by front-end and back-end services
Distinguish between the Response object returned by the API and the DDB raw object, avoid to exposing the internal data structure. response event name in api #338
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist
add new test cases
all code changes are covered by unit tests
end-to-end tests
deploy web console with CloudFront + S3 + API gateway
deploy web console within VPC
deploy ingestion server
with MSK sink
with KDS sink
with S3 sink
deploy data processing
deploy data modeling
new Redshift Serverless
provisioned Redshift
Athena
deploy with reporting
Is it a breaking change
add parameters without default value in stack
introduce new service permission in stack
introduce new top level stack module
Miscellaneous
introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend
We should not use URIs to indicate a CRUD function. URIs should only be used to identify the resources and not any action upon them uniquely. We should use HTTP request methods to indicate which CRUD function is performed.
It is not correct to put the verbs in REST URIs. REST uses nouns to represent resources, and HTTP methods (GET, POST, PUT, DELETE, etc.) are then used to perform actions on those resources, effectively acting as verbs.
We should not use URIs to indicate a CRUD function. URIs should only be used to identify the resources and not any action upon them uniquely. We should use HTTP request methods to indicate which CRUD function is performed.
It is not correct to put the verbs in REST URIs. REST uses nouns to represent resources, and HTTP methods (GET, POST, PUT, DELETE, etc.) are then used to perform actions on those resources, effectively acting as verbs.
Great suggestion! I will refactor according to this rule.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
Standardization API path to make the consistent API style #215
for example:
Define Request and Response objects for all API, shared by front-end and back-end services
Distinguish between the Response object returned by the API and the DDB raw object, avoid to exposing the internal data structure.
response event name in api #338
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist
Is it a breaking change
Miscellaneous