Check for valid E.164 format in phone numbers (#34)

* Check for valid E.164 format

* address review comments

* retrigger CI

smdebug_rulesconfig/actions/actions.py

@@ -166,7 +166,8 @@ def __init__(self, phone_number: str):
         }
         ```
 
-        :param phone_number: 10-15 digit phone number preceded by a `+`.
+        :param phone_number: Valid phone number that follows the the E.164 format. See
+            https://docs.aws.amazon.com/sns/latest/dg/sms_publish-to-phone.html for more info.
         """
         validate_phone_number("phone_number", phone_number)
         super(SMS, self).__init__(endpoint=phone_number)

smdebug_rulesconfig/actions/utils.py

@@ -2,20 +2,15 @@
 import json
 
 
-TRAINING_JOB_PREFIX_REGEX = "[A-Za-z0-9\-]+"
+TRAINING_JOB_PREFIX_REGEX = "^[A-Za-z0-9\-]+$"
 EMAIL_ADDRESS_REGEX = "^[a-z0-9]+[@]\w+[.]\w{2,3}$"
-PHONE_NUMBER_REGEX = "\+\d{10,15}"
-
-
-def _match_regex(regex, string):
-    match = re.search(regex, string)
-    return match is not None and match.start() == 0 and match.end() == len(string)
+PHONE_NUMBER_REGEX = "^\+\d{1,15}$"
 
 
 def validate_training_job_prefix(key, value):
     if not isinstance(value, str):
         raise ValueError(f"{key} must be a string!")
-    if not _match_regex(TRAINING_JOB_PREFIX_REGEX, value):
+    if not re.match(TRAINING_JOB_PREFIX_REGEX, value):
         raise ValueError(
             "Invalid training job prefix! Must contain only letters, numbers and hyphens!"
         )
@@ -24,16 +19,17 @@ def validate_training_job_prefix(key, value):
 def validate_email_address(key, value):
     if not isinstance(value, str):
         raise ValueError(f"{key} must be a string!")
-    if not _match_regex(EMAIL_ADDRESS_REGEX, value):
+    if not re.match(EMAIL_ADDRESS_REGEX, value):
         raise ValueError("Invalid email address provided! Must follow this scheme: username@domain")
 
 
 def validate_phone_number(key, value):
     if not isinstance(value, str):
         raise ValueError(f"{key} must be a string!")
-    if not _match_regex(PHONE_NUMBER_REGEX, value):
+    if not re.match(PHONE_NUMBER_REGEX, value):
         raise ValueError(
-            "Invalid phone number provided! Must be 10-15 digit number starting with a `+`!"
+            """Invalid phone number provided! Must follow the E.164 format.
+            See https://docs.aws.amazon.com/sns/latest/dg/sms_publish-to-phone.html for more info."""
         )